Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs note: azurerm_cognitive_account, not all kind support storage block #24191

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

zioproto
Copy link
Contributor

@zioproto zioproto commented Dec 11, 2023

docs note: azurerm_cognitive_account, not all kind support storage block

This needs more visibility: a lot of folks are testing OpenAI on Azure, and it is confusing what to do about the storage block.

@zioproto zioproto changed the title docs note: azurerm_cognitive_account, not all kind support storage block docs note: azurerm_cognitive_account, not all kind support storage block Dec 11, 2023
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @zioproto. I left a comment in-line if you could take a look please.

@@ -138,6 +138,8 @@ A `storage` block supports the following:

* `identity_client_id` - (Optional) The client ID of the managed identity associated with the storage resource.

~> **NOTE:** Not all `kind` support a `storage` block. For example the `kind` `OpenAI` does not support it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zioproto is there some MSFT documentation that we can link here with a definitive list of what cognitive account kinds support storage? If not then I think we should rephrase this to be more specific

Suggested change
~> **NOTE:** Not all `kind` support a `storage` block. For example the `kind` `OpenAI` does not support it.
~> **NOTE:** Cognitive Accounts with `kind` `OpenAI` do not support a `storage` block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixwa Are you able to help me with this ask ? Is it just OpenAI that does not support this ? Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephybun it seems there is not a MSFT documentation page to link that publishes this definitive list. Should we just keep the generic sentence ?

Not all `kind` support a `storage` block.

I added the OpenAI example because it is very popular and a lot of customers ask about what the storage block is for.

Please advice what changes are necessary to get this merged. Thanks

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zioproto LGTM 👍

@stephybun stephybun merged commit 0d4b1c0 into hashicorp:main Jan 24, 2024
8 checks passed
@github-actions github-actions bot added this to the v3.89.0 milestone Jan 24, 2024
Copy link

This functionality has been released in v3.89.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants